MM-61043 Error deleting board if fileID is empty #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
added
2: Dev Review
harshilsharma63
approved these changes
Oct 14, 2024
|
@Rajat-Dabade can you add the steps to reproduce this bug in the ticket? |
hmhealey
approved these changes
Oct 16, 2024
server/app/files.go
Outdated
| fileInfoID := getFileInfoID(parts[0]) | ||
|
|
||
| if (fileInfoID) == "" { | ||
| return nil, nil |
There was a problem hiding this comment.
Should this case also return an error? I'd expect that this sort of method would always return either a FileInfo or an error, but this case returns nil for both of them
There was a problem hiding this comment.
Done, returning an error with message file not found.
|
Also, excellent explanation of your investigation here. I'm surprised that we keep the file extension on the uploaded file and that we have to calculate the file ID from the filename, so it's good to know that the code works that way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://hub.mattermost.com/icu/pl/qqb9tqrzdtfajyfrysd39ecaro
Ticket Link
https://mattermost.atlassian.net/browse/MM-61043