Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-60440- fix styling when adding a new channel & board for different themes #21

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

pvev
Copy link
Contributor

@pvev pvev commented Sep 22, 2024

Summary

MM-60440- fix styling when adding a new channel & board for different themes

Ticket Link

https://mattermost.atlassian.net/browse/MM-60440

After:

Screen.Recording.2024-09-22.at.11.48.45.mov

@pvev pvev requested a review from Rajat-Dabade September 23, 2024 09:29
@pvev pvev added the 2: Dev Review Requires review by a core committer label Sep 23, 2024
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pvev
Copy link
Contributor Author

pvev commented Sep 24, 2024

thank you for the review @Rajat-Dabade , who normally review this changes for QA? Thanks

@Rajat-Dabade Rajat-Dabade added the 3: QA Review Requires review by a QA tester label Sep 24, 2024
@Rajat-Dabade
Copy link
Contributor

It's @yasserfaraazkhan who does review changes for QA. Added him as a reviewer.

@pvev pvev removed the 2: Dev Review Requires review by a core committer label Sep 26, 2024
@pvev pvev merged commit 3692ed0 into main Sep 27, 2024
6 checks passed
@pvev pvev added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants