Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bootstrap from 4.0.0-beta.2 to 4.6.2 #1361

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Update Bootstrap from 4.0.0-beta.2 to 4.6.2 #1361

merged 3 commits into from
Jun 27, 2024

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 29, 2024 •
edited
Loading

Summary

Updates Bootstrap CSS from 4.0.0-beta.2 to 4.6.2.

Note: https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js has not been used since #43 for 6+ years.

Checklist

  • diff -u <(curl -sSL https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css) site/static/css/bootstrap.min.css; echo $? should output only 0 without any diff lines.

Ticket Link

@mattermost-build
Copy link
Contributor

Hello @tnir,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@tnir
Copy link
Contributor Author

tnir commented May 1, 2024

@ccbrown Thoughts?

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@tnir tnir force-pushed the tnir-update-boostrap-from-4.0.0-beta.2-to-4.6.2 branch from c3ab2fd to 816abb3 Compare May 12, 2024 06:58
@cwarnermm cwarnermm self-requested a review May 14, 2024 20:48
@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale labels May 14, 2024
@cwarnermm cwarnermm requested review from amyblais and removed request for amyblais May 14, 2024 20:48
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed 4: Reviews Complete All reviewers have approved the pull request labels May 14, 2024
@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 816abb3

@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 56458ab

@tnir
Copy link
Contributor Author

tnir commented May 17, 2024

@cwarnermm How can I help you get this merged?

@cwarnermm
Copy link
Member

@tnir - Really appreciate your patience on this PR. Because you're proposing new tools for our tech stack, reviews will take a bit longer and involve cross-functional involvement.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm cwarnermm requested a review from emdecr May 29, 2024 19:23
@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter and removed Lifecycle/1:stale labels May 29, 2024
@github-actions GitHub Actions
Copy link

Newest code from mattermost-build has been published to preview environment for Git SHA 0fe8df6

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@tnir tnir force-pushed the tnir-update-boostrap-from-4.0.0-beta.2-to-4.6.2 branch from e7ba32f to 9d4e9c6 Compare June 13, 2024 02:54
@tnir
Copy link
Contributor Author

tnir commented Jun 13, 2024

@cwarnermm What do you think?

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@tnir
Copy link
Contributor Author

tnir commented Jun 26, 2024

@cwarnermm How can I help you?

@cwarnermm
Copy link
Member

/update-branch

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 27, 2024
@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA cb021a4

cwarnermm
cwarnermm approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tnir, for your code contribution to the Mattermost Developer Documentation, your patience as we review your PR, and your friendly reminders along the way. All appreciated.

@cwarnermm cwarnermm removed 1: Dev Review Requires review by a core commiter preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jun 27, 2024
@cwarnermm cwarnermm requested review from M-ZubairAhmed and removed request for emdecr June 27, 2024 13:03
@cwarnermm cwarnermm added the 4: Reviews Complete All reviewers have approved the pull request label Jun 27, 2024
M-ZubairAhmed
M-ZubairAhmed approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :shipit: Thank you

@cwarnermm cwarnermm merged commit c672dfa into mattermost:master Jun 27, 2024
6 checks passed
@tnir tnir deleted the tnir-update-boostrap-from-4.0.0-beta.2-to-4.6.2 branch June 27, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Bootstrap from 4.0.0-beta.2 to 4.x (latest) (4.6.2)
4 participants
@tnir @mattermost-build @cwarnermm @M-ZubairAhmed