IS-6653: Personal access token docs have outdated screenshots #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cwarnermm Please review and suggest changes, if any. Thanks. |
cwarnermm
added
2: Editor Review
|
Newest code from cwarnermm has been published to preview environment for Git SHA bb9b10c |
|
This is a great update, @Rutam21! Thank you! I'm probably being over-cautious, but I recommend that you hide additional details in the Manage Personal Tokens screenshot. I can almost make out your email address (which you likely don't want visible at all), and I also recommend blurring out some or all of the Token ID. |
|
@cwarnermm Thanks for the suggestion. I have blurred those details to the maximum extent and updated the screenshot. Also, for safety reasons, I deleted that token after raising the PR. |
cwarnermm
approved these changes
Apr 26, 2024
cwarnermm
added
4: Reviews Complete
|
@amyblais - Looking for a second approval to merge. Thanks! |
amyblais
approved these changes
Apr 26, 2024
|
@cwarnermm Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Personal Access Token page has outdated product screenshots which can be very confusing to the users. This PR adds the updated screenshots that align with the latest product and also includes additional screenshots in other sections that missed the visual references.
Ticket Link
This PR fixes mattermost/docs#6653.
Checklist