Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket Assignment Update Note #1329

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Ticket Assignment Update Note #1329

merged 6 commits into from
Jan 25, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Jan 10, 2024

Summary

This PR adds an extra note for Ticket assignment to contributors.

Ticket Link

Fixes #959

@Rutam21
Update contribution-checklist.md
f5f0d92 
Added extra note for Ticket assignment to contributors.
@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Jan 10, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Jan 16, 2024
hanzei
hanzei requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the numbering issue, LGTM 👍

site/content/contribute/more-info/getting-started/contribution-checklist.md Outdated Show resolved Hide resolved
cwarnermm
cwarnermm approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzei - I've updated the procedural numbering. This PR is ready for your approval.

@cwarnermm cwarnermm removed the 2: Editor Review Requires review by an editor label Jan 25, 2024
@cwarnermm cwarnermm requested a review from hanzei January 25, 2024 14:17
@hanzei hanzei removed the 1: Dev Review Requires review by a core commiter label Jan 25, 2024
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jan 25, 2024
@hanzei hanzei merged commit b9527df into mattermost:master Jan 25, 2024
4 checks passed
@hanzei
Copy link
Contributor

hanzei commented Jan 25, 2024

Thanks @Rutam21 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
4 participants
@Rutam21 @mattermost-build @hanzei @cwarnermm