Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[without-ssl-conf.d] Add default.conf without ssl termination option #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

a-schaefers
Copy link

Summary

Hello, for users who already have SSL termination via some load balancer within a secured VPC, it might be helpful to provide an nginx configuration option for them.

This can be [optionally, not used by default] used by those who desire it, by changing in .env the following var NGINX_CONFIG_PATH=

Original,

NGINX_CONFIG_PATH=./nginx/conf.d

Modified, for those who do not want backend SSL,

NGINX_CONFIG_PATH=./nginx/without-ssl-conf.d

Copy link

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Can you also please update the README to advertise this new configuration option?

@hanzei hanzei added Awaiting Submitter Action Blocked on the author 2: Dev Review Requires review by a core committer labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants