Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: l2 to l1 message should be searched by hash only #197

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: l2 to l1 message should be searched by hash only #197

merged 1 commit into from
Sep 22, 2023

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Sep 22, 2023 •
edited
Loading

Initially code in the pr #153 was right, but then after review it was fixed to take the n-th index of the iterator in question. However that is wrong:

  1. iterator searches for l2tol1messages by a hash
  2. the hash is unique and as such there is always only one such l2tol1message with this hash
  3. it is the neededed l2tol1message

@montekki montekki merged commit eae85c1 into main Sep 22, 2023
@montekki montekki deleted the fs-fix-l2-to-l1-message-indices branch September 22, 2023 20:22
@zksync-admin-bot2 zksync-admin-bot2 mentioned this pull request Sep 22, 2023
Merged
@zksync-admin-bot2 zksync-admin-bot2 mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaVashchuk AnastasiiaVashchuk Awaiting requested review from AnastasiiaVashchuk

@Deniallugo Deniallugo Awaiting requested review from Deniallugo Deniallugo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@montekki