chore: cleanup function modifiers

src/handlers/ERC1271Handler.sol

@@ -31,7 +31,7 @@ abstract contract ERC1271Handler is IERC1271Upgradeable, EIP712("Sso1271", "1.0.
   function isValidSignature(
     bytes32 signedHash,
     bytes memory signatureAndValidator
-  ) public view override returns (bytes4 magicValue) {
+  ) external view override returns (bytes4 magicValue) {
     (bytes memory signature, address validator) = SignatureDecoder.decodeSignatureNoHookData(signatureAndValidator);
 
     bytes32 eip712Hash = _hashTypedDataV4(_ssoMessageHash(SsoMessage(signedHash)));
@@ -59,7 +59,7 @@ abstract contract ERC1271Handler is IERC1271Upgradeable, EIP712("Sso1271", "1.0.
     return _SSO_MESSAGE_TYPEHASH;
   }
 
-  function _ssoMessageHash(SsoMessage memory ssoMessage) internal pure returns (bytes32) {
+  function _ssoMessageHash(SsoMessage memory ssoMessage) private pure returns (bytes32) {
     return keccak256(abi.encode(_SSO_MESSAGE_TYPEHASH, ssoMessage.signedHash));
   }
 }

src/libraries/JsmnSolLib.sol

@@ -57,7 +57,7 @@ library JsmnSolLib {
     return (p, t);
   }
 
-  function allocateToken(Parser memory parser, Token[] memory tokens) internal pure returns (bool, Token memory) {
+  function allocateToken(Parser memory parser, Token[] memory tokens) private pure returns (bool, Token memory) {
     if (parser.toknext >= tokens.length) {
       // no more space in tokens
       return (false, tokens[tokens.length - 1]);
@@ -68,7 +68,7 @@ library JsmnSolLib {
     return (true, token);
   }
 
-  function fillToken(Token memory token, JsmnType jsmnType, uint256 start, uint256 end) internal pure {
+  function fillToken(Token memory token, JsmnType jsmnType, uint256 start, uint256 end) private pure {
     token.jsmnType = jsmnType;
     token.start = start;
     token.startSet = true;
@@ -77,7 +77,7 @@ library JsmnSolLib {
     token.size = 0;
   }
 
-  function parseString(Parser memory parser, Token[] memory tokens, bytes memory s) internal pure returns (uint) {
+  function parseString(Parser memory parser, Token[] memory tokens, bytes memory s) private pure returns (uint) {
     uint256 start = parser.pos;
     bool success;
     Token memory token;
@@ -122,7 +122,7 @@ library JsmnSolLib {
     return RETURN_ERROR_PART;
   }
 
-  function parsePrimitive(Parser memory parser, Token[] memory tokens, bytes memory s) internal pure returns (uint) {
+  function parsePrimitive(Parser memory parser, Token[] memory tokens, bytes memory s) private pure returns (uint) {
     bool found = false;
     uint256 start = parser.pos;
     bool success;

src/managers/HookManager.sol

@@ -159,7 +159,7 @@ abstract contract HookManager is IHookManager, Auth {
     }
   }
 
-  function _addHook(bytes calldata hookAndData, bool isValidation) internal {
+  function _addHook(bytes calldata hookAndData, bool isValidation) private {
     if (hookAndData.length < 20) {
       revert Errors.EMPTY_HOOK_ADDRESS(hookAndData.length);
     }
@@ -187,7 +187,7 @@ abstract contract HookManager is IHookManager, Auth {
     emit AddHook(hookAddress);
   }
 
-  function _removeHook(address hook, bool isValidation) internal {
+  function _removeHook(address hook, bool isValidation) private {
     if (isValidation) {
       _validationHooksLinkedList().remove(hook);
     } else {
@@ -233,7 +233,7 @@ abstract contract HookManager is IHookManager, Auth {
     hookDataStore = SsoStorage.layout().hookDataStore;
   }
 
-  function _supportsHook(address hook, bool isValidation) internal view returns (bool) {
+  function _supportsHook(address hook, bool isValidation) private view returns (bool) {
     return
       isValidation
         ? hook.supportsInterface(type(IValidationHook).interfaceId)

src/managers/OwnerManager.sol

@@ -57,7 +57,7 @@ abstract contract OwnerManager is IOwnerManager, Auth {
     return _k1OwnersLinkedList().exists(addr);
   }
 
-  function _k1OwnersLinkedList() internal view returns (mapping(address => address) storage k1Owners) {
+  function _k1OwnersLinkedList() private view returns (mapping(address => address) storage k1Owners) {
     k1Owners = SsoStorage.layout().k1Owners;
   }
 

src/managers/ValidatorManager.sol

@@ -56,7 +56,7 @@ abstract contract ValidatorManager is IValidatorManager, Auth {
     emit AddModuleValidator(validator);
   }
 
-  function _removeModuleValidator(address validator) internal {
+  function _removeModuleValidator(address validator) private {
     _moduleValidatorsLinkedList().remove(validator);
 
     validator.excessivelySafeCall(gasleft(), 0, abi.encodeWithSelector(IInitable.disable.selector));
@@ -68,7 +68,7 @@ abstract contract ValidatorManager is IValidatorManager, Auth {
     return _moduleValidatorsLinkedList().exists(validator);
   }
 
-  function _supportsModuleValidator(address validator) internal view returns (bool) {
+  function _supportsModuleValidator(address validator) private view returns (bool) {
     return validator.supportsInterface(type(IModuleValidator).interfaceId);
   }
 

src/validators/SessionKeyValidator.sol

@@ -40,7 +40,7 @@ contract SessionKeyValidator is IModuleValidator {
   }
 
   // This module should not be used to validate signatures
-  function validateSignature(bytes32 signedHash, bytes memory signature) external view returns (bool) {
+  function validateSignature(bytes32 signedHash, bytes memory signature) external pure returns (bool) {
     return false;
   }
 

src/validators/WebAuthValidator.sol

@@ -36,7 +36,7 @@ contract WebAuthValidator is VerifierCaller, IModuleValidator {
   // so there's no way to just delete all the keys
   // We can only disconnect the module from the account,
   // re-linking it will allow any previous keys
-  function disable() external {
+  function disable() external pure {
     revert("Cannot disable module without removing it from account");
   }
 
@@ -160,14 +160,14 @@ contract WebAuthValidator is VerifierCaller, IModuleValidator {
   function _createMessage(
     bytes memory authenticatorData,
     bytes memory clientData
-  ) internal pure returns (bytes32 message) {
+  ) private pure returns (bytes32 message) {
     bytes32 clientDataHash = sha256(clientData);
     message = sha256(bytes.concat(authenticatorData, clientDataHash));
   }
 
   function _decodeFatSignature(
     bytes memory fatSignature
-  ) internal pure returns (bytes memory authenticatorData, string memory clientDataSuffix, bytes32[2] memory rs) {
+  ) private pure returns (bytes memory authenticatorData, string memory clientDataSuffix, bytes32[2] memory rs) {
     (authenticatorData, clientDataSuffix, rs) = abi.decode(fatSignature, (bytes, string, bytes32[2]));
   }