feat: use static salt for deploy task #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: attempt to deploy factory via create2 makes testing easier * fix: salt location * fix: stop trying to re-create the addresses Will now start to pull from the factory and compare what's different * feat: check compare with create2 Finally matches, no idea what the js issue was * fix: add tests to check each argument Encoding the beacon address was a trick that's hard to replicate * fix: remove .only from new test * fix: remove commented code for testing This is what proved that create2 was working! * feat: just use the automatic getters I'm keeping the encoding helper to avoid the ambiguity of the encoding in javascript, although it's trivial and could be done with the beacon
* chore: link to parent project Explain that the contracts are still WIP * fix: update CI action As suggested to test fixes --------- Co-authored-by: Nicolas Villanueva <[email protected]>
This is so helpful when testing locally, but carries a little risk that the code is easily front-runnable for ownership
cpb8010
force-pushed
the
static-factory-deploy
branch
from
4422b11 to
941e020
Compare
|
Something is off with the branch history here, my local branch only has 1 commit after I rebased out the merges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is so helpful when testing locally, but carries a little risk that the code is easily front-runnable for ownership
Additional context
Testing the extension is easier when I get the same addresses even after restarting the test node or redeploying unchanged code