Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove uint2str #225

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: remove uint2str #225

merged 2 commits into from
Dec 19, 2024

Conversation

cpb8010
Copy link
Contributor

@cpb8010 cpb8010 commented Dec 17, 2024

Description

Unused and doesn't work great according to the audit

Additional context

This was an open source library we're using to parse a strictly formatted JSON object, so it's probably overkill

Unused and doesn't work great according to the audit
@cpb8010 cpb8010 added the good first issue Good for newcomers label Dec 17, 2024
@cpb8010 cpb8010 requested a review from itsacoyote December 17, 2024 06:47
@cpb8010 cpb8010 self-assigned this Dec 17, 2024
@cpb8010 cpb8010 marked this pull request as ready for review December 18, 2024 07:05
Copy link
Contributor

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 795c857 into main Dec 19, 2024
3 checks passed
@MexicanAce MexicanAce deleted the remove-uint2str branch December 19, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants