Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make factory proxy work #216

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix: make factory proxy work #216

merged 4 commits into from
Dec 12, 2024

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Dec 10, 2024

Description

Previously, TransparentProxy did not work with AAFactory due to it also being an UpgradeableBeacon which

  • set the owner and impl in the factory constructor, so proxy did not have those in storage
  • had a bunch of overlapping methods between TransparentProxy and UpgradeableBeacon

This PR splits AAFactory and UpgradeableBeacon into 2 separate contracts

@ly0va ly0va merged commit e14bbf3 into main Dec 12, 2024
3 checks passed
@ly0va ly0va deleted the lyova-fix-factory-proxy branch December 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackHamer09 JackHamer09 JackHamer09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ly0va @JackHamer09