Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deployment script #213

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

MexicanAce
Copy link
Contributor

Description

  • Update the deployment scripts to remove the requirement of passing in a Private Key via command line parameters
  • Added example .env file
  • Allow funding of the paymaster when its deploying on its own
  • Update the error messages upon certain failures

Additional context

The use of private keys in command line parameters is a security risk because the PK is then stored in your shell's history and also readable if you're sharing your screen. Moving to to a .env file will help alleviate this.

@MexicanAce MexicanAce merged commit 804137d into main Dec 4, 2024
3 checks passed
@MexicanAce MexicanAce deleted the nmv/update-deployment-script branch December 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants