Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eip1271 on sessions module #198

Merged
merged 10 commits into from
Nov 25, 2024
Merged

fix: eip1271 on sessions module #198

merged 10 commits into from
Nov 25, 2024

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Nov 24, 2024 •
edited
Loading

Description

Fixes isValidSignature on the sessions module by requiring validationHook to have succeeded for the given hash. This prevents isVaidSignature from returning correct magic on all signatures regardless of whether they are valid or permitted

Base automatically changed from lyova-only-contracts to main November 25, 2024 17:28
cpb8010
cpb8010 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty silly workaround because we have two validation interfaces, but until we fix that this does make it more efficient so we don't do it twice?

@ly0va ly0va merged commit 7464e21 into main Nov 25, 2024
3 checks passed
@ly0va ly0va deleted the lyova-fix-sessions-eip1271 branch November 25, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok vladbochok left review comments

@cpb8010 cpb8010 cpb8010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ly0va @cpb8010 @vladbochok