Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove hardcoded gas, fix estimation, sdk improvements #193

Merged
merged 54 commits into from
Nov 20, 2024
Merged

fix: remove hardcoded gas, fix estimation, sdk improvements #193

merged 54 commits into from
Nov 20, 2024

Conversation

JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Nov 20, 2024 •
edited
Loading

Description

  • Undo hardcoded estimations
  • Fix estimations on SDK level
  • Fix error on logout
  • Add support for wagmi getConnectorClient by exporting client in the connector
  • Use README.md from root during NPM package deployment

Additional context

ly0va and others added 30 commits November 1, 2024 12:05
@ly0va
feat: store sessions offchain to reduce gas
17daeb5
@ly0va
feat: signer assertion and more events
d628d0c
@ly0va
chore: update abi
82fc11d
@ly0va
fix: remove max_constraints
efd733a
@ly0va
chore: rename
edb2472
@ly0va
Merge remote-tracking branch 'origin/main' into lyova-offchain-sessions
8789160
@ly0va
fix: update abi
9c5db07
@ly0va
fix: gas estimation
3bce3f0
@ly0va
chore: add more logs
109a2fb
@ly0va
Merge branch 'main' into lyova-offchain-sessions
56c4be3
@ly0va
chore: update sdk
077ec6e
@ly0va
feat: pass session in sdk
9e5a417
@ly0va
fix: sdk bug
fbefbfe
@ly0va
fix: remove hardcoded gas limits
499c680
@ly0va
fix: leave hardcoded gas limit in sdk for now
89c631c
@ly0va
Merge branch 'main' into lyova-offchain-sessions
5bb0d63
@JackHamer09
Merge branch 'main' into lyova-offchain-sessions
677fa53
@JackHamer09
fix: session interface improvements
2bd1bb3
@JackHamer09
fix: enable ci and fix docs
c0578b3
@JackHamer09
fix: readme formatting
4bc524d
@JackHamer09
fix: remove redundant workflow triggers
13b4e07
@JackHamer09
fix: update contract addresses
f404b9e
@JackHamer09
fix: update addresses
d09bd78
@JackHamer09
fix: popup communicator
6659e39
@JackHamer09
Merge branch 'lyova-offchain-sessions' of https://github.com/matter-l…
9ece621 
…abs/zksync-account-sdk into session-interface-improvements
@JackHamer09
fix: e2e
827512c
@JackHamer09
fix: move session defaults out of computed
95c3af8
@JackHamer09
fix: rename fee to feeLimit
c7636ba
@JackHamer09
fix: limit zero incorrect LimitType
fd4333c
@JackHamer09
fix: remove session spec, which is copy of createSession from abi
f2fb3fd
JackHamer09 and others added 19 commits November 13, 2024 15:34
@JackHamer09
fix: remove redundant bigint conversions
da9aa0d
@JackHamer09
fix: update interface to support specifying limit type
c762d9d
@JackHamer09
fix: use unlimited default limit for calls constraints
c008cc0
@ly0va
Merge pull request #164 from matter-labs/session-interface-improvements
78d30d3 
fix: session interface improvements
@JackHamer09
Merge branch 'main' into lyova-offchain-sessions
ff882e5
@JackHamer09
fix: pass custom signature during session transaction estimation
3499fe2
@JackHamer09
fix: try fix estimation
580a529
@JackHamer09
Revert "fix: try fix estimation"
4092f84 
This reverts commit 580a529.
@JackHamer09
Revert "fix: pass custom signature during session transaction estimat…
94faafc 
…ion"

This reverts commit 3499fe2.
@JackHamer09
Reapply "fix: pass custom signature during session transaction estima…
6e8aac5 
…tion"

This reverts commit 94faafc.
@JackHamer09
Reapply "fix: try fix estimation"
a5f5123 
This reverts commit 4092f84.
@JackHamer09
Merge branch 'main' into fix-estimation
ad58810
@JackHamer09
fix: some more updates, getting closer to figure out the issue
59a4a02
@JackHamer09
fix: estimation
5403531
@JackHamer09
fix: undo hardocde data and gasPerPubdata
bf99429
@JackHamer09
fix: undo using gas price
710edc3
@JackHamer09
Merge branch 'main' of https://github.com/matter-labs/zksync-account-sdk
9311342 
 into fix-estimation
@JackHamer09
Merge branch 'main' into fix-estimation
d22aaf0
@JackHamer09
fix: sdk improvements
4ae8789
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d8c3f76):

https://zksync-auth-server-staging--pr193-fix-estimation-3g08ddzf.web.app

(expires Wed, 27 Nov 2024 15:49:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7

@JackHamer09 JackHamer09 changed the title fix: remove hardcoded gas, fix estimation, minor sdk improvements fix: remove hardcoded gas, fix estimation, sdk improvements Nov 20, 2024
itsacoyote
itsacoyote reviewed Nov 20, 2024
View reviewed changes
packages/sdk/.gitignore Outdated Show resolved Hide resolved
packages/sdk/prepare-package.mjs Outdated Show resolved Hide resolved
@JackHamer09 JackHamer09 merged commit d90a94d into main Nov 20, 2024
7 checks passed
@JackHamer09 JackHamer09 deleted the fix-estimation branch November 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsacoyote itsacoyote itsacoyote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackHamer09 @itsacoyote @ly0va