fix: rename cleanup v2 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 851bd60): https://zksync-auth-server-staging--pr188-use-old-interface-yf4q8gt4.web.app (expires Thu, 28 Nov 2024 12:46:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
Attempting to deploy to sepolia and updating the contract locations is harder than just changing the interface which still exists and is compatiable
This reverts commit 0bf91c6. There's an extra allow-list for the factory that would have fixed this
cpb8010
force-pushed
the
use-old-interface
branch
from
e8818d2 to
afd0fee
Compare
cpb8010
commented
Nov 20, 2024
I had added this for backwards compatibility, thinking we'd update the front-end and the old front-end would need to work with the new back end. Instead the deployment process might be reversed, where we update the back-end and the front-end will point to the old back-end during the rollover.
cpb8010
changed the title
Still need to deploy to sepolia and get addresses for that?
Will open up the allow-list PR for commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
There's an extra deploy step we have to co-ordinate related to the AAFactory address changes.