chore(nft-quest): disable 1password form saver #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackHamer09
previously approved these changes
Nov 19, 2024
yuliyaalexiev
requested changes
Nov 19, 2024
itsacoyote
force-pushed
the
disable-1p
branch
from
7bbf0bf to
714780b
Compare
yuliyaalexiev
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1Password wants to try and be really helpful on saving data from forms. This disables the 1password from displaying a dropdown on the share mint input for NFT Quest. This does not prevent 1Password from potentially popping up a window after clicking the button to mint. That's a larger account/system level configuration the user would have to disable overall.
Evidence