chore: rename to reflect SSO interface #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has diverged from Clave and did not make the cut for 7579 compatiability, so we're renaming whatever is in between to SSO. We may add back the 7579 interfaces if we get 4337 relayer support in the future, but otherwise we were just inspiried by it instead of compliant.
|
Visit the preview URL for this PR (updated for commit 3042d73): https://zksync-auth-server-staging--pr185-rename-cleanup-4sg567sa.web.app (expires Tue, 26 Nov 2024 18:19:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
This only updates the in memory node as I don't want to deploy to sepolia until those tests pass
vladbochok
reviewed
Nov 19, 2024
| @@ -19,14 +19,22 @@ contract AAFactory is UpgradeableBeacon { | |||
| beaconProxyBytecodeHash = _beaconProxyBytecodeHash; | |||
| } | |||
|
|
|||
| function addNewUniqueId(bytes32 uniqueAccountId) external {} | |||
|
|
|||
| function deployProxy7579Account( | |||
There was a problem hiding this comment.
@vladbochok let's merge this and rename in #183
ly0va
approved these changes
Nov 19, 2024
cpb8010
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
This has diverged from Clave and did not make the cut for 7579
compatiability, so we're renaming whatever is in between to SSO.
We may add back the 7579 interfaces if we get 4337 relayer support in
the future, but otherwise we were just inspiried by it instead of
compliant.