fix: disable user verification #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ccb9f7b): https://zksync-auth-server-staging--pr180-user-verification-haa4031p.web.app (expires Tue, 26 Nov 2024 16:36:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 509a9c9ea42583076f531c53cf2979c544d5d0b7 |
We have a user who is getting this error even when it defaults to preferred, and we're discouraging it in other places. Also attempting to block Winodws Hello before hasn't been successful, as Chrome thinks we should be able to support it.
cpb8010
force-pushed
the
user-verification
branch
from
dfb6493 to
ccb9f7b
Compare
JackHamer09
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a user who is getting this error even when it defaults to preferred, and we're discouraging it in other places. Also attempting to block Windows Hello before hasn't been successful, as Chrome thinks we should be able to support it.
Additional context
Evidence
Signing in with Windows (on edge) works when using the "use mobile authenticator" option.
Changing the supported algorithms didn't change Windows showing PIN/FaceId, and it looks like it worked at least within the PR, so it's possible that Windows Hello can use ES256? It could also just be the test setup here.