Skip to content

Commit

Permalink
fix: remove commented code for testing
Browse files Browse the repository at this point in the history
This is what proved that create2 was working!
  • Loading branch information
cpb8010 committed Dec 13, 2024
1 parent c6ada48 commit e1a48e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
5 changes: 0 additions & 5 deletions src/AAFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { DEPLOYER_SYSTEM_CONTRACT, IContractDeployer } from "@matterlabs/zksync-
import { SystemContractsCaller } from "@matterlabs/zksync-contracts/l2/system-contracts/libraries/SystemContractsCaller.sol";

import { ISsoAccount } from "./interfaces/ISsoAccount.sol";
import { AccountProxy } from "./AccountProxy.sol";

/// @title AAFactory
/// @author Matter Labs
Expand Down Expand Up @@ -59,10 +58,6 @@ contract AAFactory {
) external returns (address accountAddress) {
require(accountMappings[_uniqueAccountId] == address(0), "Account already exists");

/*
AccountProxy beaconProxy = new AccountProxy{ salt: _salt }(beacon);
accountAddress = address(beaconProxy);
*/
(bool success, bytes memory returnData) = SystemContractsCaller.systemCallWithReturndata(
uint32(gasleft()),
address(DEPLOYER_SYSTEM_CONTRACT),
Expand Down
6 changes: 2 additions & 4 deletions test/BasicTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@ import { assert, expect } from "chai";
import { ethers, parseEther, randomBytes } from "ethers";
import { Wallet, ZeroAddress } from "ethers";
import { it } from "mocha";
import { ContractFactory, SmartAccount, utils } from "zksync-ethers";
import { SmartAccount, utils } from "zksync-ethers";

import { SsoAccount__factory } from "../typechain-types";
import { CallStruct } from "../typechain-types/src/batch/BatchCaller";
import { ContractFixtures, create2, ethersStaticSalt, getProvider } from "./utils";

import * as hre from "hardhat";
import { ContractFixtures, getProvider } from "./utils";

describe("Basic tests", function () {
const fixtures = new ContractFixtures();
Expand Down

0 comments on commit e1a48e7

Please sign in to comment.