Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sdk docs to nav #55

Merged
merged 3 commits into from
May 9, 2024
+4 −0
Merged

chore: add sdk docs to nav #55

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7beaa4c
chore: add sdk docs to nav
dutterbutter May 8, 2024
0e1c2bb
chore: update url
dutterbutter May 9, 2024
acd4fed
chore: update url
dutterbutter May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ const links = computed(() => {
to: '/build',
active: route.path.startsWith('/build'),
},
{
label: 'SDK Docs',
to: 'https://zksync-sdk-docs-staging.web.app',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just to get the links up there temporarily for testing? Otherwise we want to set this up for linking to the proper endpoint per environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we can set this to '/sdk' and the cloudflare rules should still be able to handle redirecting to the SDK endpoint?

{
label: 'ZK Stack',
to: '/zk-stack',
Expand Down
Loading