Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and debug section #16

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Test and debug section #16

merged 7 commits into from
Apr 18, 2024

Conversation

itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented Apr 15, 2024

What 💻

  • Add test and debug section to docs

@itsacoyote itsacoyote force-pushed the test-and-debug-section branch from 4624ce9 to 6ff1a5a Compare April 16, 2024 16:04
@itsacoyote itsacoyote marked this pull request as ready for review April 16, 2024 16:05
@itsacoyote itsacoyote requested a review from a team as a code owner April 16, 2024 16:05
@itsacoyote itsacoyote requested a review from dutterbutter April 16, 2024 19:04
Copy link

github-actions bot commented Apr 16, 2024

Visit the preview URL for this PR (updated for commit 77226d3):

https://zksync-docs-staging-5eb09--pr16-test-and-debug-secti-w0royj5d.web.app

(expires Thu, 25 Apr 2024 19:44:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed.

content/60.test-and-debug/10.dockerized-l1-l2-nodes.md Outdated Show resolved Hide resolved
content/60.test-and-debug/20.in-memory-node.md Outdated Show resolved Hide resolved

You can send network calls against a running `era_test_node`.
<!-- Why is there a LINK? Also is USDT still the proper code? -->
You can check the Sepolia testnet LINK balance or mainnet USDT using `curl` or :external-link{text="foundry-zksync" href="https://github.com/matter-labs/foundry-zksync"}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LINK is the name of the token

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does LINK come from? I'm not familiar with why it's in the context of this section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its poorly worded and we can remove, as example does not make use of it at all. I think the intent was you can check the balance of these different erc20 tokens. However the example, does not reflect the sentence at all so we can remove.

content/60.test-and-debug/20.in-memory-node.md Outdated Show resolved Hide resolved
content/60.test-and-debug/20.in-memory-node.md Outdated Show resolved Hide resolved
content/60.test-and-debug/20.in-memory-node.md Outdated Show resolved Hide resolved
content/60.test-and-debug/20.in-memory-node.md Outdated Show resolved Hide resolved
content/60.test-and-debug/40.hardhat.md Outdated Show resolved Hide resolved
content/60.test-and-debug/40.hardhat.md Outdated Show resolved Hide resolved
content/60.test-and-debug/40.hardhat.md Outdated Show resolved Hide resolved
@itsacoyote itsacoyote force-pushed the test-and-debug-section branch 2 times, most recently from 6bcb9af to c586c8d Compare April 18, 2024 13:53
@itsacoyote itsacoyote force-pushed the test-and-debug-section branch from c586c8d to 00af8bd Compare April 18, 2024 13:59
@itsacoyote itsacoyote requested a review from dutterbutter April 18, 2024 14:13
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment re: LINK / USDT

@itsacoyote itsacoyote merged commit 44b0d41 into staging Apr 18, 2024
7 checks passed
@itsacoyote itsacoyote deleted the test-and-debug-section branch April 18, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants