Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial quickcode guide for deploying contract using hardhat or foundry #10

Merged
merged 13 commits into from
Apr 15, 2024

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Apr 2, 2024

What 💻

  • Adds initial quickstart guide framework
  • Adds components for organizing content
  • Adds reusable content in partials

Why ✋

  • Includes quickstart for deploying, factories, testing, upgrading, and general paymaster flow
  • Components are helpful for displaying and organizing content

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Copy link

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit bd29f18):

https://zksync-docs-staging-5eb09--pr10-db-quickcode-guide-ad616y3l.web.app

(expires Mon, 22 Apr 2024 17:57:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

@dutterbutter
Copy link
Contributor Author

@itsacoyote looks awesome! One thought, curious your opinion here, it seems to me that the spacing between tags is rather large. Do you feel the same? Reviewing that preview, it just seems like a lot of white space to me, idk.

@itsacoyote
Copy link
Contributor

@dutterbutter I also feel like it's a little larger than I like, but it's following automatic styling for paragraph tags. The difference between this change and the previous is one is paragraph tags for each line vs an unordered list.

This was an extremely quick implementation to clean up the components and use something "cheap". I do prefer some tighter styling on the list and make it an actual list later on down the line.

@dutterbutter dutterbutter force-pushed the db/quickcode-guide branch 2 times, most recently from 95c6ea6 to 3d471f7 Compare April 11, 2024 18:43
@dutterbutter dutterbutter marked this pull request as ready for review April 12, 2024 03:30
@dutterbutter dutterbutter requested a review from a team as a code owner April 12, 2024 03:30
content/10.quick-start/1.index.md Outdated Show resolved Hide resolved
content/_partials/_environment-setup-with-zksync-cli.md Outdated Show resolved Hide resolved
content/_partials/_environment-setup-with-zksync-cli.md Outdated Show resolved Hide resolved
content/10.quick-start/_index/_hardhat_deploy_contract.md Outdated Show resolved Hide resolved
content/10.quick-start/5.paymaster.md Outdated Show resolved Hide resolved
@dutterbutter dutterbutter requested a review from itsacoyote April 15, 2024 17:58
@dutterbutter dutterbutter merged commit 89e025e into staging Apr 15, 2024
7 checks passed
@dutterbutter dutterbutter deleted the db/quickcode-guide branch April 15, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants