-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial quickcode guide for deploying contract using hardhat or foundry #10
Conversation
Visit the preview URL for this PR (updated for commit bd29f18): https://zksync-docs-staging-5eb09--pr10-db-quickcode-guide-ad616y3l.web.app (expires Mon, 22 Apr 2024 17:57:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11 |
@itsacoyote looks awesome! One thought, curious your opinion here, it seems to me that the spacing between tags is rather large. Do you feel the same? Reviewing that preview, it just seems like a lot of white space to me, idk. |
@dutterbutter I also feel like it's a little larger than I like, but it's following automatic styling for paragraph tags. The difference between this change and the previous is one is paragraph tags for each line vs an unordered list. This was an extremely quick implementation to clean up the components and use something "cheap". I do prefer some tighter styling on the list and make it an actual list later on down the line. |
95c6ea6
to
3d471f7
Compare
* Hello zkSync * Contract factories * Testing * Upgrades * Paymaster - wip
chore: remove getting_started default
ea8af8a
to
dc4d1b0
Compare
What 💻
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intended