Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update naming from era_test_node to anvil-zksync #1567

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Dec 4, 2024

What πŸ’»

  • Updates to make use of anvil-zksync

Why βœ‹

  • era-test-node renamed to anvil-zksync

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes πŸ“

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@dutterbutter dutterbutter marked this pull request as ready for review December 4, 2024 15:06
@dutterbutter dutterbutter requested a review from a team as a code owner December 4, 2024 15:06
@dutterbutter dutterbutter requested a review from Romsters December 4, 2024 16:28
Copy link
Contributor

@Romsters Romsters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix e2e please

@kiriyaga-txfusion
Copy link
Contributor

fix e2e please

Redirecting the era-test-node repository to anvil-zksync will break all older plugins, as the redirection was designed to reduce GitHub API usage and prevent users from hitting API rate limits. This issue is evident in failing e2e tests, which rely on older plugin versions.

@dutterbutter dutterbutter merged commit 707f461 into main Dec 10, 2024
21 checks passed
@dutterbutter dutterbutter deleted the db/update-hh-node branch December 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants