feat(zk): zksolc linking #800

Karrq · 2024-12-20T21:37:01Z

What 💻

Add functions to use zksolc --link
Process deploy-time linking (CREATE only)
Update default zksolc to 1.5.8

Why ✋

Allow tests & scripts to rely on contracts with libraries that have not been deployed yet

Notes 📝

There's a simple merge conflicts due to the lack of access to DualCompiledContracts during the MultiContractRunner instantiation.

This is a working yet incomplete implementation, as such there are a few quirks, in particular: unlinked factory deps are not supported (zksolc 1.5.9 should have some extra info that we can use), linking via CREATE2 is not supported either yet.

Currently there's an issue with trying to actually run the library, I believe due to a missing storage migration:

2024-12-20T21:22:57.842992Z ERROR suite{name=CounterTest}:test{kind=test name=testIncrement}:call:inspect: foundry_zksync_core::vm::tracers::cheatcode: call may fail or behave unexpectedly due to empty code target=0x0e93455c2327dc24ac46d3a2edade6dbb6260629 calldata="771602f70000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

chore: identify action to deploy libs in EraVM

crates/evm/evm/src/executors/strategy.rs

crates/forge/src/multi_runner.rs

crates/linking/src/lib.rs

crates/strategy/zksync/src/executor.rs

crates/zksync/compilers/src/link.rs

crates/zksync/core/src/lib.rs

crates/config/src/zksync.rs

elfedy · 2025-01-13T14:52:44Z

crates/forge/src/multi_runner.rs

+                        .find(|(id, _)| id.source == needle.source && id.name == needle.name)
+                        .map(|(_, evm)| (needle, zk, evm))
+                })
+                .filter(|(_, zk, evm)| zk.bytecode.is_some() && evm.bytecode.is_some())


Shouldn't this be more of an assertion than a filter? Is it ok to keep on executing if we are missing some of the bytecodes?

It would simply not be added to the dual_compiled_contracts like it was before if it was unlinked (read as invalid bytecode)

Ok, I am just worried we would filter something we should be aware it's missing (for example what happened when using zksolc previous to 1.5.7 and trying to just deserialize the eravm field to get the bytecode) and then this fails later when trying to get the bytecode and takes a bit to debug and track it is being filetred here. If this cannot happen then we are good.

There are also some contracts which aren't meant to have bytecode like interfaces etc... Not sure the implications here tbh

crates/forge/src/multi_runner.rs

crates/forge/tests/it/zk/linking.rs

crates/linking/src/lib.rs

crates/strategy/zksync/src/executor.rs

crates/zksync/compiler/src/lib.rs

crates/zksync/compilers/src/lib.rs

crates/zksync/compilers/src/dual_compiled_contracts.rs

fix(strategy): remove get_mut for `DualCompiledContracts`

fix(zk:link): use version from config refactor(zk:config): extract config -> zksolc compiler logic into function chore: lints

chore: remove accidental file re-inclusion

refactor(zk:link): avoid attempting to link fully-linked contracts

feat(script:zk): link with zksolc

feat(zk): zksolc linking

d6489ae

Karrq self-assigned this Dec 20, 2024

Karrq requested a review from a team as a code owner December 20, 2024 21:37

Karrq added 7 commits January 7, 2025 17:53

fix(zk:libs): calculate addresses w/ proper nonce

e5b805d

chore: identify action to deploy libs in EraVM

Merge remote-tracking branch 'origin/main' into feat/zksolc-link

44aebad

Merge remote-tracking branch 'origin/main' into feat/zksolc-link

f5dcfa1

fix: don't always assume DCC is present

262d2a7

feat(executor): deploy_library in strategy

b79cada

fix(zk): create address computation

1941e33

chore: cleanup unused imports

93babb9

nbaztec reviewed Jan 10, 2025

View reviewed changes

Karrq added 2 commits January 10, 2025 19:02

test(zk): deploy-time linking (script/test)

5ed5154

chore: default zksolc to 1.5.8

018f3f0