Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sanitize input based on solc version #690

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: sanitize input based on solc version #690

merged 1 commit into from
Nov 1, 2024

Conversation

dutterbutter
Copy link
Collaborator

What 💻

  • Sanitizes settings based on solc version prior to verification request

Why ✋

  • Verification was failing for some solc versions due to evm_version always being Cancun

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter requested a review from a team as a code owner November 1, 2024 19:50
@dutterbutter dutterbutter added the needs review 👓 PR requires a review label Nov 1, 2024
Karrq
Karrq approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - I thought it weird since it's coming from the config loaded by foundry, but now I see that the L1 source provider also does the sanitization

@dutterbutter dutterbutter merged commit 883034d into main Nov 1, 2024
12 checks passed
@dutterbutter dutterbutter deleted the db/fix-verification-for-0.8.19 branch November 1, 2024 20:03
@dutterbutter dutterbutter mentioned this pull request Nov 4, 2024
Closed
2 tasks
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

Assignees
No one assigned
Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutterbutter @Karrq