fix: Create2Factory on scripts #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
requested changes
Sep 16, 2024
nbaztec
reviewed
Sep 17, 2024
nbaztec
reviewed
Sep 17, 2024
nbaztec
reviewed
Sep 17, 2024
…create2 factory deps
nbaztec
reviewed
Sep 17, 2024
Co-authored-by: Nisheeth Barthwal <[email protected]>
Karrq
reviewed
Sep 17, 2024
nbaztec
reviewed
Sep 17, 2024
Karrq
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using create2 in a script does not work as expected, as mentioned in this issue. Create2 was working for tests, but due to a check in the scripting process, we were unable to deploy it correctly in this case.
Solution
Adapt the script flow to use the create2Factory deployed in zksync