Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove zk-tests in favor of cargo tests #556

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

Jrigada
Copy link
Contributor

@Jrigada Jrigada commented Aug 30, 2024

Motivation

We've migrated successfully the zk-tests test suite to cargo tests

Solution

Delete the zk-test directory

@Jrigada Jrigada marked this pull request as ready for review September 4, 2024 14:04
elfedy
elfedy previously approved these changes Sep 4, 2024
nbaztec
nbaztec previously approved these changes Sep 4, 2024
.github/workflows/secret_scanner.yaml Outdated Show resolved Hide resolved
@Jrigada Jrigada dismissed stale reviews from nbaztec and elfedy via 847e527 September 5, 2024 13:47
@Jrigada Jrigada requested a review from elfedy September 5, 2024 14:06
@Jrigada Jrigada merged commit a69c479 into main Sep 5, 2024
11 checks passed
@Jrigada Jrigada deleted the jrigada-remove-zk-tests branch September 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants