test(zk): cheatcode usage in zkVm #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
approved these changes
Aug 21, 2024
|
|
||
| function getZkBalance(Vm vm, address target) public view returns (uint256) { | ||
| vm.zkVm(true); | ||
| getNonce(vm, target); |
There was a problem hiding this comment.
so this gets executed in evm even though the vm.zkVm(true) is before this, and it would only run things in zkVm if a CALL happens from that point on right?
There was a problem hiding this comment.
Partially correct: in this instance, getNonce is an internal call, thus the VM is not switched before executing it, but if any call happens inside it (or we access storage translated data) then yes, it will use zkVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cheatcodes are not supported in zkVm, but there are no tests that display this limitation
Solution
Provide a test case which shows this limitation and also potential pattern to avoid a given contract from being executed in zkVm and thus circumvent this limtation