feat: implement changes for zksolc 1.5.1 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jrigada
approved these changes
Jul 24, 2024
| let abi_json = &solc_metadata_json["output"]["abi"]; | ||
| let abi_string = abi_json.to_string(); | ||
| let abi: JsonAbi = JsonAbi::from_json_str(&abi_string)?; | ||
| let ZkContractArtifact { bytecode, hash, factory_dependencies, abi, .. } = artifact; |
| output_selection: OutputSelection { | ||
| all: Some(FileOutputSelection { | ||
| per_file: None, | ||
| per_contract: Some([OutputSelectionFlag::ABI].into()), |
There was a problem hiding this comment.
Nice, are we sure we don't use some fields that used to be present like the metadata? I think it would came up just as invariant testing but just wondering.
There was a problem hiding this comment.
I don't think so, we use the bytecodes but those are always output. If something comes up we can add it then
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
1.5.0 renames system_mode to enable_vm_extensions and moved some cli flags to std json.
1.5.1 does not output fields that are specified in output selection.
Solution
Adapt configs and defaults to those changes and make 1.5.1 the default compiler.
Related PRs
Needs Moonsong-Labs/compilers#15