feat: Blockhash returning expected value #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jrigada
changed the title
elfedy
reviewed
Jul 19, 2024
elfedy
approved these changes
Jul 19, 2024
elfedy
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, the CheatcodeTracer was configured to override the blockhash calls and return 0. This approach was a temporary solution to ensure consistency in the environment data being returned.
Solution
This PR updates the CheatcodeTracer to retrieve and return the actual L1 blockhashes. By intercepting the blockhash calls within the tracer, we ensure that the environment data being returned is consistent with the real L1 blockhashes. This change enhances the accuracy and reliability of the environment data, providing a more realistic testing and debugging experience.