Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): bump solc to 0.8.26 #474

Merged
merged 4 commits into from
Jul 23, 2024
Merged

chore(test): bump solc to 0.8.26 #474

merged 4 commits into from
Jul 23, 2024

Conversation

elfedy
Copy link
Contributor

@elfedy elfedy commented Jul 12, 2024

Motivation

Compilation in smoke test was failing with default evm version (cancun) as we were using an incompatible solc version.

Solution

Use solc 0.8.26 for tests

Base automatically changed from foundry-update-4af6cfa to dev July 22, 2024 13:45
@elfedy elfedy force-pushed the elfedy-bump-test-solc branch from 7ec66d1 to c3d9bf4 Compare July 22, 2024 17:38
Copy link
Contributor

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So paris is incompatible with 0.8.26?

@elfedy
Copy link
Contributor Author

elfedy commented Jul 23, 2024

So paris is incompatible with 0.8.26?

It is compatible. We changed our default evm to cancun and 0.8.20 does not support this, that's why we were setting evm to paris in our tests.

@elfedy elfedy merged commit baab5e6 into dev Jul 23, 2024
11 checks passed
@elfedy elfedy deleted the elfedy-bump-test-solc branch July 23, 2024 16:20
@elfedy elfedy changed the title chore(test): bump solc to 0.26.0 chore(test): bump solc to 0.8.26 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants