-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create in upstream merge #462
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7d98f38
fix(script:zk): use EIP712 for zk deployments
Karrq 876a3b9
fix(transact): use inspect_ref_zk with zk_tx data
Karrq 2b678d9
fix(script): restore `EthereumWallet`
Karrq e304aee
fix(broadcast:zk): avoid gas_price unwrap
Karrq 9661ad8
fix(zk): get proper signature v
Karrq e64b653
chore: cleanup
Karrq 1e91037
Merge branch 'foundry-update-4af6cfa' into fix/script
nbaztec 4db8016
fix create
nbaztec d639c48
Merge branch 'foundry-update-4af6cfa' into nish-fix-upstream-create
nbaztec fb81c05
fix create
nbaztec 06dcf4f
remove dead code
nbaztec a7a2565
Update crates/forge/bin/cmd/create.rs
nbaztec 0b0d32e
review
nbaztec 6ee5879
Merge branch 'nish-fix-upstream-create' of github.com:matter-labs/fou…
nbaztec 10a67b7
remove max_fee_per_gas, use default data
nbaztec 60531c2
Merge branch 'foundry-update-4af6cfa' into nish-fix-upstream-create
nbaztec 0f1c58e
cleanup
nbaztec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move zk related helpers to a respective module/crate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can refactor this once we have a better picture.
In general it's easier to have everything in one place, but we need to plan it properly as most times the "zk" functions are a copy-paste of the original ones with a few modifications. So when a upstream merge comes, we want to include those updates to the original function.