feat: startBroadcast and stopBroadcast cheatcodes
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
changed the title
startBroadcast and stopBroadcaststartBroadcast and stopBroadcast cheatcodes
|
@MexicanAce this is necessary for truly testing |
Karrq
force-pushed
the
karrq/feat/cheatcode-ss-broadcast
branch
from
2321284 to
9f128f0
Compare
Karrq
changed the title
startBroadcast and stopBroadcast cheatcodesstartBroadcast and stopBroadcast cheatcodes
Karrq
force-pushed
the
karrq/feat/cheatcode-ss-broadcast
branch
from
1775058 to
ab1ff83
Compare
Karrq
changed the title
startBroadcast and stopBroadcast cheatcodesstartBroadcast and stopBroadcast cheatcodes
nbaztec
reviewed
Jan 5, 2024
nbaztec
reviewed
Jan 5, 2024
Jrigada
changed the title
startBroadcast and stopBroadcast cheatcodesstartBroadcast and stopBroadcast cheatcodes
nbaztec
reviewed
Jan 5, 2024
nbaztec
approved these changes
Jan 5, 2024
Karrq
force-pushed
the
karrq/feat/cheatcode-ss-broadcast
branch
from
751b989 to
50873dc
Compare
|
Rebased on top of |
refactor(era:cc:broadcast): start/stop broadcast helpers tests(era::cc:broadcast): simple test file
tests(era:cc:broadcast): add test for value, gas limit and nonce refactor(era:cc): extract get/set nonce into method
Karrq
force-pushed
the
karrq/feat/cheatcode-ss-broadcast
branch
from
50873dc to
3d43013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
startBroadcastandstopBroadcastcheatcodesEvidence 📷
Notes:
The broadcast tests are a bit of a false positive, the broadcast cheatcodes collect call data to generate transactions that can be broadcasted on chain - thus it has no observable effect in solidity.