Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge cheatcodes contract interface #196

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

aon
Copy link

@aon aon commented Dec 14, 2023

What πŸ’»

  • Uses contract interface defined in the cheatcodes spec for era-cheatcodes.

Why βœ‹

  • Reduces code duplication
  • Prevents diverging interfaces

Evidence πŸ“·

image

@aon aon requested review from nbaztec and dutterbutter December 14, 2023 12:57
@@ -20,6 +20,8 @@ multivm.workspace = true
zksync_web3_decl.workspace = true
zksync_utils.workspace = true
foundry-evm-core.workspace = true
foundry-cheatcodes-spec.workspace = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the best possible change ❀️

@dutterbutter dutterbutter merged commit 8fadab3 into main Dec 14, 2023
11 checks passed
@dutterbutter dutterbutter deleted the aon-merge-cheatcodes-interface branch December 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants