Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache compiled files via zksolc #194

Merged
merged 6 commits into from
Dec 13, 2023
Merged

feat: cache compiled files via zksolc #194

merged 6 commits into from
Dec 13, 2023

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Dec 13, 2023

What 💻

  • Caches compiled artifacts from zksolc output to avoid recompiling them on each test run

Why ✋

  • Causes huge delays while running tests multiple times.

Evidence 📷

image

dutterbutter
dutterbutter approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice time saver!! 🚀

@nbaztec nbaztec merged commit 3fb6c03 into main Dec 13, 2023
11 checks passed
@nbaztec nbaztec deleted the nish-cache-compile branch December 13, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @dutterbutter