Renaming + fixing test

Rename it back so the compiler understand
fixing the test to assert for the missing library

crates/config/src/zksync.rs

@@ -136,7 +136,7 @@ impl ZkSyncConfig {
             via_ir: Some(via_ir),
             // Set in project paths.
             remappings: Vec::new(),
-            zk_detect_missing_libraries: self.zk_detect_missing_libraries,
+            detect_missing_libraries: self.zk_detect_missing_libraries,
             enable_eravm_extensions: self.enable_eravm_extensions,
             force_evmla: self.force_evmla,
             llvm_options: self.llvm_options.clone(),

crates/forge/bin/cmd/build.rs

@@ -15,6 +15,7 @@ use foundry_config::{
         value::{Dict, Map, Value},
         Metadata, Profile, Provider,
     },
+    zksync::config_create_project,
     Config,
 };
 use serde::Serialize;
@@ -90,10 +91,6 @@ impl BuildArgs {
             config = self.load_config();
         }
 
-        if self.zk_detect_missing_libraries {
-            config.zksync.zk_detect_missing_libraries = true;
-        }
-
         if !config.zksync.should_compile() {
             let project = config.project()?;
 
@@ -130,8 +127,15 @@ impl BuildArgs {
             // no way to return a default from either branch. Ok(output)
             Ok(())
         } else {
-            let zk_project =
-                foundry_config::zksync::config_create_project(&config, config.cache, false)?;
+            let mut zk_project = config_create_project(&config, config.cache, false)?;
+
+            // Note: This is to pass the zk_detect_missing_libraries flag to the zk compiler only
+            // while building.
+            zk_project.settings.settings.detect_missing_libraries =
+                self.zk_detect_missing_libraries;
+
+            // sh_print!("Compiling ZK contracts...")?;
+            // sh_println!("zk_project.settings.settings: {:?}", zk_project.settings.settings)?;
 
             // Collect sources to compile if build subdirectories specified.
             let mut files = vec![];

crates/forge/tests/cli/build.rs

@@ -1,7 +1,8 @@
 use crate::utils::generate_large_contract;
 use foundry_config::{zksync::ZkSyncConfig, Config};
-use foundry_test_utils::{forgetest, snapbox::IntoData, str};
+use foundry_test_utils::{forgetest, snapbox::IntoData, str, util::OutputExt};
 use globset::Glob;
+use std::fs;
 
 forgetest_init!(can_parse_build_filters, |prj, cmd| {
     prj.clear();
@@ -209,14 +210,42 @@ contract ValidContract {}
     cmd.args(["build"]).assert_success();
 });
 
-forgetest_init!(test_zk_build_missing_libraries_as_arg, |prj, cmd| {
-    cmd.args(["build", "--zksync", "--zk-detect-missing-libraries"]).assert_success();
-});
+forgetest!(test_zk_build_with_missing_libraries_as_arg, |prj, cmd| {
+    prj.add_source(
+        "Foo",
+        r#"
+library Foo {
+    function get_something() external returns (uint256 c) {}
+}
+   "#,
+    )
+    .unwrap();
 
-forgetest_init!(test_zk_build_missing_libraries_as_config, |prj, cmd| {
-    let zk = ZkSyncConfig { zk_detect_missing_libraries: true, ..Default::default() };
-    prj.write_config(Config { zksync: zk, ..Default::default() });
-    cmd.args(["build", "--zksync", "--zk-detect-missing-libraries"]).assert_success();
+    prj.add_source(
+        "UsesFoo",
+        r#"
+import "./Foo.sol";
+contract UsesFoo {
+    uint256 something;
+
+    constructor() {
+        something = Foo.get_something();
+    }
+}
+"#,
+    )
+    .unwrap();
+
+    // cmd.args(["build", "--zksync", "--zk-detect-missing-libraries", "--json"]).assert_success();
+    cmd.args(["build", "--zksync", "--zk-detect-missing-libraries", "--json", "--force"])
+        .assert_success()
+        .stdout_eq(str![[r#"
+...
+            "missingLibraries": [
+              "src/Foo.sol:Foo"
+            ]
+...
+"#]]);
 });
 
 forgetest_init!(test_zk_missing_libraries_param_only_on_build, |prj, cmd| {

crates/zksync/compilers/src/compilers/zksolc/settings.rs

@@ -112,7 +112,7 @@ pub struct ZkSettings {
     /// Switch to missing deployable libraries detection mode.
     /// Contracts are not compiled in this mode, and all compilation artifacts are not included.
     #[serde(default, rename = "detectMissingLibraries")]
-    pub zk_detect_missing_libraries: bool,
+    pub detect_missing_libraries: bool,
     // zksolc arguments
     /// A flag indicating whether to enable the system contract compilation mode.
     /// Whether to enable EraVM extensions.
@@ -204,7 +204,7 @@ impl Default for ZkSettings {
             via_ir: None,
             libraries: Default::default(),
             remappings: Default::default(),
-            zk_detect_missing_libraries: false,
+            detect_missing_libraries: false,
             enable_eravm_extensions: false,
             llvm_options: Default::default(),
             force_evmla: false,
@@ -244,7 +244,7 @@ impl CompilerSettings for ZkSolcSettings {
                     optimizer,
                     metadata,
                     libraries,
-                    zk_detect_missing_libraries,
+                    detect_missing_libraries,
                     enable_eravm_extensions,
                     llvm_options,
                     force_evmla,
@@ -262,7 +262,7 @@ impl CompilerSettings for ZkSolcSettings {
             *optimizer == other.settings.optimizer &&
             *metadata == other.settings.metadata &&
             *libraries == other.settings.libraries &&
-            *zk_detect_missing_libraries == other.settings.zk_detect_missing_libraries &&
+            *detect_missing_libraries == other.settings.detect_missing_libraries &&
             *enable_eravm_extensions == other.settings.enable_eravm_extensions &&
             *llvm_options == other.settings.llvm_options &&
             *force_evmla == other.settings.force_evmla &&