Fix SYSTEM_CONTRACTS_OFFSET preprocessing #1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
requested review from
vladbochok and
StanislavBreadless
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes #802. The content of this PR hasn't been created by me, it's the cherry-picked commit b6b351e by @kelemeno from branch kl/interop that has an open PR #676. As of now the PR seems stuck, it fails the CI, has no reviews or comments, and got no new commits in 4 months. If this PR is merged, the parent PR should get no merge issues because the changes are a plain cherry-pick with no modifications.
Why ❔
Issue #802 breaks compilation of the constants Solidity file. This file is one of the main reasons to include this repository as a dependency of smart contracts that are to be deployed on zkSync. It has been broken for many months now and there's no quick fix in sight and no easy workaround except switching to maintaining the constants by hand.
Checklist