Fix slither issues

matter-labs · Dec 11, 2024 · a43d2cf · a43d2cf
1 parent e4c49c3
commit a43d2cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol b/l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol
@@ -122,8 +122,9 @@ contract AdminFacet is ZkSyncHyperchainBase, IAdmin {
         emit NewTransactionFilterer(oldTransactionFilterer, _transactionFilterer);
     }
 
-    function allowEvmEmulation() external onlyAdmin {
-        IMailbox(address(this)).requestL2ServiceTransaction(
+    /// @inheritdoc IAdmin
+    function allowEvmEmulation() external onlyAdmin returns (bytes32 canonicalTxHash) {
+        canonicalTxHash = IMailbox(address(this)).requestL2ServiceTransaction(
             L2_DEPLOYER_SYSTEM_CONTRACT_ADDR,
             abi.encodeCall(IL2ContractDeployer.setAllowedBytecodeTypesToDeploy, AllowedBytecodeTypes.EraVmAndEVM)
         );

diff --git a/l1-contracts/contracts/state-transition/chain-interfaces/IAdmin.sol b/l1-contracts/contracts/state-transition/chain-interfaces/IAdmin.sol
@@ -47,7 +47,7 @@ interface IAdmin is IZkSyncHyperchainBase {
     function setTransactionFilterer(address _transactionFilterer) external;
 
     /// @notice Allow EVM emulation on chain
-    function allowEvmEmulation() external;
+    function allowEvmEmulation() external returns (bytes32 canonicalTxHash);
 
     /// @notice Perform the upgrade from the current protocol version with the corresponding upgrade data
     /// @param _protocolVersion The current protocol version from which upgrade is executed