Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use base repo for reference benchmarks and head_ref for tests #25

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

  • For forks, always use base repo for the reference testing in benchmarks
  • Use head_ref in the base scenario for forks integration tests to not take main by default with workflow_call. This leads to issues when some other branch (not main) in forks repositories is used, and main is not rebased from the upstream repo.

Why ❔

We have to prevent a situation when a fork repository main branch is not rebased, but some other branch is.

Checklist

  • PR title corresponds to the body of PR.
  • Documentation comments have been added / updated.

hedgar2017
hedgar2017 previously approved these changes Aug 27, 2024
@antonbaliasnikov antonbaliasnikov merged commit 2fbb151 into main Aug 27, 2024
1 check passed
@antonbaliasnikov antonbaliasnikov deleted the aba-fix-forks-branches branch August 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants