Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base-token): automatic fetching #187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fborello-lambda
Copy link

What ❔

Provide a way to track the Base and ETH tokens.

Why ❔

Maybe the blockExplorerApi is not set and the tokens are not specified in the config file, so if everything fails, ask the RPC for the main tokens.

How to Reproduce ❔

I've created a hyperchain with basetoken, then npm run hyperchain:create and finally: npm run dev:node:hyperchain

Note

I also have a block explorer running but the api is not working, what's the solution for this? or how can i test it out?

If i do:

curl -X 'GET' \
  'http://block-explorer:3020/tokens?page=1&limit=10&minLiquidity=0' \
  -H 'accept: application/json'

I get:

{
  "items": [],
  "meta": {
    "totalItems": 0,
    "itemCount": 0,
    "itemsPerPage": 10,
    "totalPages": 0,
    "currentPage": 1
  },
  "links": {
    "first": "tokens?limit=10&minLiquidity=0",
    "previous": "",
    "next": "",
    "last": ""
  }
}

It doesn't even return the base-token address

I've seen that the mainnet blockExplorerApi doesn't even have this method. How are extra tokens managed? By just looking at the code, seems that the tokens are manually predefined is that the case?

@fborello-lambda fborello-lambda force-pushed the feat_automatic_bt_fetch branch from ed38a20 to 7a26484 Compare August 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant