Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comment #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some typos in comment #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,4 @@ GitHub Actions test results are available in:
- Inside of each test run in the log: `Feature on Mainnet + Sepolia` --> `@search` --> `Upload test results to Allure reporter` --> `https://raw.githack.com/matter-labs/block-explorer/gh-pages/_github.run_number_/index.html`
- Directly via a link `https://raw.githack.com/matter-labs/block-explorer/gh-pages/_github.run_number_/index.html` after each PR running. The history of test runs for public view locates in `gh-pages` branch.

In case of 404 page, make sure that the folder with its `github.run_number` exists in the `gh-pages`. If the folder exist, try again in a few minutes as `https://raw.githack.com` needs to update the data. Public report link will be available when the 'Allure Report' job will be succesfully executed.
In case of 404 page, make sure that the folder with its `github.run_number` exists in the `gh-pages`. If the folder exist, try again in a few minutes as `https://raw.githack.com` needs to update the data. Public report link will be available when the 'Allure Report' job will be successfully executed.
4 changes: 2 additions & 2 deletions packages/worker/diagrams/batches-processing.flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ flowchart
GetLastBatchFromDB --> SetLastDBBatch(Set lastProcessedBatchNumber variable with last batch number from DB)
CheckIfLastProcessedBatchNumberIsNull --> |No| GetNextBatchFromBlockchain
SetLastDBBatch --> GetNextBatchFromBlockchain("Get the next batch from blockchain (lastProcessedBatchNumber + 1)")
GetNextBatchFromBlockchain --> CheckIfRequestSuccessful{Is request sucessful ?}
GetNextBatchFromBlockchain --> CheckIfRequestSuccessful{Is request successful ?}
CheckIfRequestSuccessful --> |No| ResetLastDBBatch(Set lastProcessedBatchNumber = NULL)
CheckIfRequestSuccessful --> |Yes| CheckIfBatchExists{Does the next batch exist ?}
CheckIfBatchExists --> |No| ResetLastDBBatch(Set lastProcessedBatchNumber = NULL)
Expand All @@ -28,6 +28,6 @@ Batch state is defined and used only internally. There are 4 batch states: `Exec
- `Executed` - batch has `executeTxHash` and `executedAt`.
- `Proven` - batch has `proveTxHash` and `provenAt`.
- `Committed` - batch has `commitTxHash` and `committedAt`.
- `New` - batch does't have any of `executeTxHash`, `proveTxHash` or `commitTxHash`.
- `New` - batch doesn't have any of `executeTxHash`, `proveTxHash` or `commitTxHash`.

Note, each `Executed` batch is also `Proven` and `Committed`, each `Proven` batch is also `Committed`.