Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: new formatting and screenshots addition #231

Closed
wants to merge 37 commits into from
Closed

test: new formatting and screenshots addition #231

wants to merge 37 commits into from

Conversation

olehbairak
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

amelnytskyi and others added 30 commits February 6, 2024 19:31
@amelnytskyi
feat: adding docusaurus docs project
6e4bd01 
Adding initial scope of Docusaurus project for testing docs
@amelnytskyi
feat: adding docusaurus docs project
3315bcc 
Updating dependencies
@otani88
add job workflow for build testing docs
cc99738
@otani88
add job workflow for build testing docs
6af93f2
@otani88
add job workflow for build testing docs
d947f6a
@otani88
Merge branch 'main' into QA-613-add-docusaurus-docs-project
bb5d2a6
@otani88
change docusaurus config for deploy
e7bbf7f
@otani88
re-configure build for use custom dns
ee17988
@otani88
re-configure build for use custom dns
aa2824f
@otani88
add workflow for build and publish test docs
9c981ba
@amelnytskyi
adding instructions to readme
610e366
@amelnytskyi
Merge branch 'main' into QA-613-add-docusaurus-docs-project
606b748
@pcheremu
test: fix package build on CI in docs workflow
ec4eaa3
@pcheremu
test: debug npm build
ef3a3b4
@pcheremu
test: debug npm build without husky
367756d
@pcheremu
test: test build
0c083aa
@pcheremu
test: test build
e278b79
@pcheremu
test: build docs
fefd445
@pcheremu
test: build docs
de4df79
@pcheremu
test: workable run of doc, do not run npm i for testing-docs
bdf931e
@pcheremu
test: fix node dependencies (#223)
a0ecd01 
# What ❔

fix npm issues 

## Why ❔

Conflict in react packages: To resolve build with latest deps first. 

## Checklist


- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
@pcheremu
test: tests migration from allure
34ccf3b
@pcheremu
test: added migration script
8580045
@olehbairak
test: remove extra symbols to avoid 404 pages redirection (#229)
42fabcb 
# What ❔

Removing extra symbols that prevents page from loading.
After the test cases were imported from Allure project - some of the
pages didn't load because of the different symbols.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
@amelnytskyi @pcheremu
test: fixing folders structure for BE docs in docusaurus project (#227)
8b5b518 
# What ❔

- Removed obsolete Blogs and Tutorials docs
- fixing folders structure for BE docs (docusaurus project)
- cleaned index page 

## Why ❔


## Checklist


- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.

---------

Co-authored-by: pcheremu <[email protected]>
@pcheremu
test: test docs deployment
209808c
@pcheremu
test: test docs deployment
0dd0842
@pcheremu
test: debug docs workflow
48ab2fd
@pcheremu
test: debug docs workflow
caa0303
@pcheremu
test: debug docs workflow
43f6c2f
@olehbairak olehbairak self-assigned this Apr 15, 2024
@olehbairak olehbairak changed the base branch from main to QA-613-add-docusaurus-docs-project April 15, 2024 14:27
@olehbairak olehbairak added the documentation Improvements or additions to documentation label Apr 15, 2024
@olehbairak olehbairak marked this pull request as ready for review April 15, 2024 15:34
@olehbairak olehbairak requested a review from pcheremu April 15, 2024 15:34
pcheremu
pcheremu reviewed Apr 16, 2024
View reviewed changes
...navigation - Production/id565 - Networks navigation Prod - Common - Navigation to Sepolia.md Outdated
@@ -0,0 +1,17 @@
---
tags: ['Full test', 'manual', 'Navigation', 'Network', 'regression', 'To Automate', 'ZKF-2507', 'Active']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olehbairak Do we decide to remove all ZKF-**** tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.
Thank you!

pcheremu
pcheremu reviewed Apr 16, 2024
View reviewed changes
...- Staging/id562 - Networks navigation Staging - Common - Navigation to zkSync Era Testnet.md Outdated
@@ -0,0 +1,17 @@
---
tags: ['Full test', 'manual', 'Navigation', 'Network', 'Smoke test', 'ZKF-2507', 'Automated']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, can you please sort/select/take attention is the test case 'manual' or 'automated'? We have to keep only one of this tags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.
Thank you!

pcheremu
pcheremu reviewed Apr 16, 2024
View reviewed changes
...ges/testing-docs/docs/BE Tests/Common /Blockscout API /id546 - API - Common - Get balance.md

## Scenario
- Prepare a custom token on L2
- Make a request to show the balance
- ?module=account&action=tokenlist&address=\{hash\}
- You can see the token with its balance
- ![Screenshot](../../../../static/img/screenshots/common/BlockscoutAPI/id546_1.png);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pcheremu
Copy link
Contributor

@olehbairak Please create a task to clean extra ZKF tags and check if test case contains only one (manual or automated tag). feel free to merge this PR to the initial and create another one based on linear task or make this fix in the same PR. @amelnytskyi fyi

@olehbairak olehbairak requested a review from pcheremu April 16, 2024 09:08
pcheremu
pcheremu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212
tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

@olehbairak
Copy link
Contributor Author

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Yes, totally agree. We need to define whether these is the same, cause in fact they are partly automated, or to have only one identifier.

@amelnytskyi
Copy link
Contributor

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Let's have only 'Active Partly Manual' for such cases - WDYT?

@pcheremu
Copy link
Contributor

Yep, Lets keep only one tag the will describe the status. And be careful with signing that we unexpectedly see here.

pcheremu
pcheremu suggested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commits should be signed

@pcheremu pcheremu changed the base branch from QA-613-add-docusaurus-docs-project to main April 16, 2024 11:06
@pcheremu pcheremu changed the base branch from main to QA-613-add-docusaurus-docs-project April 16, 2024 11:06
@olehbairak olehbairak closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcheremu pcheremu pcheremu requested changes

Assignees

@olehbairak olehbairak

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olehbairak @pcheremu @amelnytskyi @otani88