fix: preserve apiUrl path segment #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What?
Replaced `URL(path, apiUrl)` with `URL(\`${apiUrl}/${path}\`)` to ensure the apiUrl's path segment is preserved during URL construction.
Why?
The existing code did not properly handle cases where the apiUrl includes a path (e.g., "https://.../api").
The original method of using `URL(path, apiUrl)` incorrectly stripped away the path segment (e.g., `/api`) from the apiUrl, leading to incorrect URLs.
This change also enhances the codebase's consistency, as this method of constructing URLs is used in most other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Replaced
URL(path, apiUrl)withURL(`${apiUrl}/${path}`)to ensure the apiUrl's path segment is preserved during URL construction.Why ❔
The existing code did not properly handle cases where the apiUrl includes a path (e.g., "https://.../api"). The original method of using
URL(path, apiUrl)incorrectly stripped away the path segment (e.g.,/api) from the apiUrl, leading to incorrect URLs. This change also enhances the codebase's consistency, as this method of constructing URLs is used in most other places.