Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release process with release-please #549

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antonbaliasnikov
Copy link

@antonbaliasnikov antonbaliasnikov commented Jan 17, 2025

What 💻

  • Add release-please configuration and workflows
  • Update Docker image with cargo chef build stage that allows the proper layers caching improving docker image building time from ~30 min to ~15 min.
  • Add GH attestations to Docker images as well as for binaries
  • Add the capability to manually trigger binary release workflow to generate a prerelease for testing purposes
  • Create only one attestation for all binaries instead of individual attestation for each binary per platform.

@antonbaliasnikov antonbaliasnikov force-pushed the 474-releases-improve-automated-releases-and-review branch 6 times, most recently from da93b4a to 7db8cb0 Compare January 17, 2025 16:57
@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review January 17, 2025 16:58
@antonbaliasnikov antonbaliasnikov requested a review from a team as a code owner January 17, 2025 16:58
@antonbaliasnikov antonbaliasnikov force-pushed the 474-releases-improve-automated-releases-and-review branch from 7db8cb0 to 452459d Compare January 17, 2025 17:19
@dutterbutter
Copy link
Collaborator

dutterbutter commented Jan 17, 2025

@antonbaliasnikov were you able to test successfully in a fork by any chance? I suppose this will also Closes #474

@antonbaliasnikov
Copy link
Author

@antonbaliasnikov were you able to test successfully in a fork by any chance? I suppose this will also Closes #474

@dutterbutter , I've tested it in this PR by enabling pull_request target and making sure that docker and binaries are successfully built.

In the fork, I've tested release-please as well, here is a next release PR example:
antonbaliasnikov#2
But I will test a bit more as I found see some issues with release-please tagging.

I suppose this will also Closes #474
Yes, it will. Is is aligned with the issue through the git branch name.

But we need to discuss minor details with you and @itegulov about the flow. Because release-please will always create the release first, and only then we start jobs to add binaries and publish docker images. We can re-try them if they fail, but anyway it would be nice to discuss the flow we would like to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants