Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add binary attestation #511

Merged
merged 1 commit into from
Jan 7, 2025
Merged

feat: Add binary attestation #511

merged 1 commit into from
Jan 7, 2025

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Jan 7, 2025

What πŸ’»

Adds binary attestations for releases (for now, only for binaries).
See action

Why βœ‹

Allows to verify the validity of the binary. See gh attestation verify

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@popzxc popzxc requested a review from a team as a code owner January 7, 2025 05:59
@popzxc popzxc force-pushed the popzxc-add-attestations branch 2 times, most recently from 256437e to 071efb3 Compare January 7, 2025 06:18
@popzxc popzxc force-pushed the popzxc-add-attestations branch from 071efb3 to d8bc617 Compare January 7, 2025 06:27
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Trusting you that the binaries are verifiable - tried building a binary from your branch but obviously its SHA ended up being different from what CI produced. Any way, very cool feature!

@popzxc popzxc merged commit 43e544f into main Jan 7, 2025
14 checks passed
@popzxc popzxc deleted the popzxc-add-attestations branch January 7, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants