-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Marko #149
Add Marko #149
Conversation
tigt
commented
Jan 31, 2023
- Depends on Tweak some samples for clarity and better behavior in playgrounds #148 to be consistent with other frameworks — I have no problems editing them back if that doesn’t get merged, however
- Places Marko with the other resumable frameworks (if there’s other logic for how the frameworks are sorted, I’d love to know)
- Updated the contribution guidelines with what I had to figure out to get the Playground URL working
- Some of the Marko playground URLs produce interesting errors — those are bugs on our end, we’ll fix them out of band
Everything except for the TS declarations since I think Dylan ought to weigh in Co-authored-by: Michael Rawlings <[email protected]> Co-authored-by: Luke LaValva <[email protected]>
Oh, uh, I’d be happy to fix up my WIP commit history if your repo doesn’t squash upon merge |
Thanks a lot ! Hope we can find a solution to #148 PR, then I'll review it |
If you can submit this PR without playground issues, we'll be able to add Marko. |
Roger. Might be a little bit before I get that update in — just left eBay |
Okay, I changed the Viewport Size and mixed checkbox examples back to Page Title and autofocused input. |