Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4011: Thumbnail media negotiation #4011
base: main
Are you sure you want to change the base?
MSC4011: Thumbnail media negotiation #4011
Changes from 2 commits
f405f7c
2cf2b13
ed0555c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There stands to be a reasonable improvement for bridges, in that we could start requesting more compact formats when bridging images/videos etc to external networks. For instance, we could convert images to webp upon bridging to Discord if we wanted to, rather than serving the current files.
Bridges stand to benefit in about the same way as clients, albeit possibly unless the remote client limits our upload sizes it's probably not such a huge concern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSC2700 also discusses thumbnail requirements. MSC2705 also mentions requirements, though in different context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I hadn't had a chance yet to fully search for alternatives. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSC2705 has now dropped its content type requirements, though MSC2702 imposes some strong recommendations (should be compatible with this MSC).
I'm closing MSC2700 in favour of this MSC.