Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecate imports #4565

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Nov 28, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922

  • Replace some legacy crypto imports
  • Deprecate CryptoBackend.getEventEncryptionInfo

@florianduros florianduros added T-Task Tasks for the team like planning T-Deprecation A pull request that makes something deprecated labels Nov 28, 2024
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ask, looks good.

@@ -78,6 +78,7 @@ export interface CryptoBackend extends SyncCryptoCallbacks, CryptoApi {
* Get information about the encryption of an event
*
* @param event - event to be checked
* @deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here? What method to use instead would be helpful.

@florianduros florianduros added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit edac6a9 Nov 29, 2024
28 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/deprecate-import branch November 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Deprecation A pull request that makes something deprecated T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants