Unrevert prerelease fix, and fix release error #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I *think* this will fix a problem with the release process in which we saw an error: ``` Error: Invalid configuration for file "/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json": Error: module is not defined in ES module scope Error: This file is being treated as an ES module because it has a '.js' file extension and '/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension. ```
dbkr
approved these changes
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Aug 20, 2024
For the same reason as matrix-org/matrix-js-sdk#4353
4 tasks
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Aug 20, 2024
For the same reason as matrix-org/matrix-js-sdk#4353
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Aug 20, 2024
For the same reason as matrix-org/matrix-js-sdk#4353
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply "Add "type" = "module" to ensure it is present (Ensure "type" = "module" ES declaration in pre-release.sh #4350)"
Mark prettier config file as CommonJS
I think this will fix a problem with the release process in which we saw an error: