MXStore: Add a method to remove all the messages sent before a specific timestamp in a room. #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuroe
reviewed
May 12, 2020
There was a problem hiding this comment.
We should expose this method at the MXRoom level instead of using MXStore directly.
The [MXRoom removeAllMessagesSentBefore:] should call [store commit] to be sure that the change is actually stored (and not 30s max later on the next sync).
MXRoom should also:
- reset the room summary if needed
- reset the current timeline (but it is probably best to do nothing at SDK level for that and let the app refresh itself)
Co-authored-by: manuroe <[email protected]>
Co-authored-by: manuroe <[email protected]>
# Conflicts: # CHANGES.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the messages sent before a specific timestamp in a room.
The state events are not removed during this operation. We keep them in the timeline.
This operation doesn't change the pagination token, and the flag indicating that the SDK has reached the end of pagination.